Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove useless code #1205

Merged
merged 3 commits into from
Jun 15, 2019
Merged

remove useless code #1205

merged 3 commits into from
Jun 15, 2019

Conversation

zhaoyuguang
Copy link
Member

Ⅰ. Describe what this PR did

In LockStoreDataBaseDAO::doAcquireLock, The internal property ResultSet and related code are not necessary.

@codecov-io
Copy link

codecov-io commented Jun 14, 2019

Codecov Report

Merging #1205 into develop will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1205      +/-   ##
=============================================
+ Coverage      43.53%   43.54%   +0.01%     
  Complexity      1428     1428              
=============================================
  Files            250      250              
  Lines          10213    10208       -5     
  Branches        1331     1330       -1     
=============================================
- Hits            4446     4445       -1     
+ Misses          5182     5179       -3     
+ Partials         585      584       -1
Impacted Files Coverage Δ Complexity Δ
...a/io/seata/core/store/db/LockStoreDataBaseDAO.java 49.01% <ø> (+0.91%) 18 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fcba69...6efe4d8. Read the comment docs.

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@slievrly slievrly changed the title format code remove useless code Jun 15, 2019
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 1f898c8 into apache:develop Jun 15, 2019
@leizhiyuan leizhiyuan added this to the 0.7.0 milestone Jul 10, 2019
nick-tan pushed a commit to nick-tan/seata that referenced this pull request Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants