Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setting default values using trinomial operators #1206

Merged
merged 5 commits into from
Jun 15, 2019

Conversation

andyqian
Copy link
Contributor

Ⅰ. Describe what this PR did

修改默认值方式,以及魔法值

@codecov-io
Copy link

codecov-io commented Jun 14, 2019

Codecov Report

Merging #1206 into develop will increase coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1206      +/-   ##
=============================================
+ Coverage      43.51%   43.54%   +0.02%     
  Complexity      1428     1428              
=============================================
  Files            250      250              
  Lines          10222    10213       -9     
  Branches        1331     1331              
=============================================
- Hits            4448     4447       -1     
+ Misses          5189     5182       -7     
+ Partials         585      584       -1
Impacted Files Coverage Δ Complexity Δ
...in/java/io/seata/spring/util/SpringProxyUtils.java 3.7% <0%> (-1.66%) 3 <0> (ø)
...java/io/seata/spring/tcc/TccActionInterceptor.java 12.82% <0%> (ø) 2 <0> (ø) ⬇️
...java/io/seata/rm/datasource/ConnectionContext.java 13.63% <0%> (+0.87%) 3 <0> (ø) ⬇️
...ing/annotation/GlobalTransactionalInterceptor.java 10.16% <0%> (-0.95%) 2 <0> (ø)
...server/store/file/FileTransactionStoreManager.java 47.38% <0%> (+0.34%) 19% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7584fc7...caaa08b. Read the comment docs.

@xingfudeshi
Copy link
Member

Thanks for contribution.please change the title in English.

@andyqian andyqian changed the title 1. 将默认值修改为三目运算符,以及修改魔法值 1. Setting default values using trinomial operators Jun 15, 2019
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly changed the title 1. Setting default values using trinomial operators setting default values using trinomial operators Jun 15, 2019
@slievrly slievrly merged commit 5fcba69 into apache:develop Jun 15, 2019
@leizhiyuan leizhiyuan added this to the 0.7.0 milestone Jul 10, 2019
nick-tan pushed a commit to nick-tan/seata that referenced this pull request Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants