Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All overriding methods must be preceded by @Override annotations. #1207

Merged
merged 1 commit into from
Jun 15, 2019
Merged

All overriding methods must be preceded by @Override annotations. #1207

merged 1 commit into from
Jun 15, 2019

Conversation

zhaoyuguang
Copy link
Member

Ⅰ. Describe what this PR did

All overriding methods must be preceded by @OverRide annotations.

slievrly
slievrly approved these changes Jun 14, 2019
View reviewed changes
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ujjboy
ujjboy approved these changes Jun 15, 2019
View reviewed changes
Copy link
Contributor

@ujjboy ujjboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ujjboy ujjboy merged commit 7437852 into apache:develop Jun 15, 2019
@fescar-robot fescar-robot mentioned this pull request Jun 21, 2019
Closed
@leizhiyuan leizhiyuan added this to the 0.7.0 milestone Jul 10, 2019
nick-tan pushed a commit to nick-tan/seata that referenced this pull request Jul 12, 2019
@zhaoyuguang @nick-tan
Add @OverRide annotation in overriding methods. (apache#1207)
2d62496
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ujjboy ujjboy ujjboy approved these changes

@slievrly slievrly slievrly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zhaoyuguang @ujjboy @slievrly @leizhiyuan