add config shutdown.wait and update version to 0.7.0-SNAPSHOT
#1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: slievrly <slievrly@163.com>
|
In the tiltle,the version may be 0.7.0-SNAPSHOT? |
slievrly
changed the title
shutdown.wait and update version to 0.7.1-SNAPSHOTshutdown.wait and update version to 0.7.0-SNAPSHOT
yes, i fix it. |
lovepoem
requested changes
Jun 18, 2019
| @@ -31,7 +31,7 @@ | |||
| /** | |||
| * The constant CURRENT. | |||
| */ | |||
| public static final String CURRENT = "0.6.1"; | |||
| public static final String CURRENT = "0.7.0"; | |||
There was a problem hiding this comment.
How about use the version configured in pom.xml dynamicly?
There was a problem hiding this comment.
or the version in meta-info of the jar ?
There was a problem hiding this comment.
But when we run with IDE, there is no meta-info here.
There was a problem hiding this comment.
But when we run with IDE, there is no meta-info here.
It is a question , we can retain this issue temporarily and merge this pr
lovepoem
approved these changes
Jun 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: slievrly slievrly@163.com
Ⅰ. Describe what this PR did
add config
shutdown.waitand update version to 0.7.1-SNAPSHOTⅡ. Does this pull request fix one issue?
fix #1212
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews