-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix:containsPK ignoreCase #1218
Conversation
Signed-off-by: slievrly <slievrly@163.com>
Codecov Report
@@ Coverage Diff @@
## develop #1218 +/- ##
=============================================
- Coverage 43.94% 43.93% -0.02%
- Complexity 1447 1451 +4
=============================================
Files 253 253
Lines 10262 10272 +10
Branches 1332 1335 +3
=============================================
+ Hits 4510 4513 +3
- Misses 5171 5176 +5
- Partials 581 583 +2
Continue to review full report at Codecov.
|
if (null == sourceList || sourceList.size() == 0) { return sourceList; } | ||
List<String> destList = new ArrayList<>(sourceList.size()); | ||
for (String element : sourceList) { | ||
destList.add(element.toUpperCase()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Element needs to check null.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
great found.i will fix it. |
Signed-off-by: slievrly <slievrly@163.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: slievrly slievrly@163.com
Ⅰ. Describe what this PR did
bugfix:containsPK ignoreCase
Ⅱ. Does this pull request fix one issue?
fix #1217 #1176
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews