Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix in which SQL and database field names are inconsistent#1217 #1221

Merged
merged 2 commits into from
Jun 19, 2019

Conversation

xionganyin
Copy link
Contributor

Fix Rm cannot find primary key when primary key is Uppercase in sql ,using MySQL.
fixes #1217

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Briefly write pr, which will be used as the commit log. Such as bugfix: xxxx.

@xionganyin xionganyin changed the title Fix Rm cannot find primary key when primary key is Uppercase in sql ,… bugfix:sql与数据库字段名大小写不一致bug修复#1217 Jun 19, 2019
@xionganyin xionganyin changed the title bugfix:sql与数据库字段名大小写不一致bug修复#1217 bugfix:Bug fixes in which SQL and database field names are inconsistent#1217 Jun 19, 2019
@slievrly slievrly changed the title bugfix:Bug fixes in which SQL and database field names are inconsistent#1217 bugfix: fix in which SQL and database field names are inconsistent#1217 Jun 19, 2019
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

Codecov Report

Merging #1221 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1221   +/-   ##
==========================================
  Coverage      43.48%   43.48%           
  Complexity      1428     1428           
==========================================
  Files            250      250           
  Lines          10218    10218           
  Branches        1330     1330           
==========================================
  Hits            4443     4443           
- Misses          5190     5191    +1     
+ Partials         585      584    -1
Impacted Files Coverage Δ Complexity Δ
...o/seata/rm/datasource/sql/struct/TableRecords.java 73.77% <100%> (ø) 13 <0> (ø) ⬇️
...server/store/file/FileTransactionStoreManager.java 46.34% <0%> (ø) 19% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ec37c8...1e3d8c8. Read the comment docs.

@xingfudeshi xingfudeshi merged commit 7fefe47 into apache:develop Jun 19, 2019
@leizhiyuan leizhiyuan added this to the 0.7.0 milestone Jul 10, 2019
nick-tan pushed a commit to nick-tan/seata that referenced this pull request Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rm cannot find primary key when primary key is Uppercase in sql ,using MySQL.
5 participants