Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a typo #1229

Merged
merged 9 commits into from
Jun 20, 2019
Merged

fix a typo #1229

merged 9 commits into from
Jun 20, 2019

Conversation

LintelXu
Copy link
Contributor

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Jun 20, 2019

Codecov Report

Merging #1229 into develop will increase coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1229      +/-   ##
=============================================
+ Coverage      43.93%   43.96%   +0.02%     
  Complexity      1451     1451              
=============================================
  Files            253      253              
  Lines          10272    10272              
  Branches        1335     1335              
=============================================
+ Hits            4513     4516       +3     
+ Misses          5176     5174       -2     
+ Partials         583      582       -1
Impacted Files Coverage Δ Complexity Δ
...eata/core/rpc/netty/NettyClientChannelManager.java 70.27% <0%> (ø) 22 <0> (ø) ⬇️
...server/store/file/FileTransactionStoreManager.java 47.03% <0%> (+1.04%) 19% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db51b52...85b238b. Read the comment docs.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit eeb1dbe into apache:develop Jun 20, 2019
@leizhiyuan leizhiyuan modified the milestone: 0.7.0 Jul 10, 2019
nick-tan pushed a commit to nick-tan/seata that referenced this pull request Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants