-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prioritize global transaction scanner #1227 #1230
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1230 +/- ##
=============================================
- Coverage 43.93% 43.92% -0.01%
Complexity 1451 1451
=============================================
Files 253 253
Lines 10272 10274 +2
Branches 1335 1335
=============================================
Hits 4513 4513
- Misses 5176 5178 +2
Partials 583 583
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Ⅰ. Describe what this PR did
prioritize global transaction scanner
Ⅱ. Does this pull request fix one issue?
fix #1227
Ⅲ. Why don't you add test cases (unit test/integration test)?
ensure order of bean initialization by BeanFactoryPostProcessor & PriorityOrdered is already verified.
Ⅳ. Describe how to verify it
Bean annotated with TwoPhaseBusinessAction is a part of a TCC transaction.
Ⅴ. Special notes for reviews