Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prioritize global transaction scanner #1227 #1230

Merged
merged 10 commits into from
Jun 25, 2019
Merged

Conversation

awkejiang
Copy link
Contributor

Ⅰ. Describe what this PR did

prioritize global transaction scanner

Ⅱ. Does this pull request fix one issue?

fix #1227

Ⅲ. Why don't you add test cases (unit test/integration test)?

ensure order of bean initialization by BeanFactoryPostProcessor & PriorityOrdered is already verified.

Ⅳ. Describe how to verify it

Bean annotated with TwoPhaseBusinessAction is a part of a TCC transaction.

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Jun 20, 2019

Codecov Report

Merging #1230 into develop will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1230      +/-   ##
=============================================
- Coverage      43.93%   43.92%   -0.01%     
  Complexity      1451     1451              
=============================================
  Files            253      253              
  Lines          10272    10274       +2     
  Branches        1335     1335              
=============================================
  Hits            4513     4513              
- Misses          5176     5178       +2     
  Partials         583      583
Impacted Files Coverage Δ Complexity Δ
...ta/spring/annotation/GlobalTransactionScanner.java 55.55% <0%> (-1.15%) 17 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eeb1dbe...8178a92. Read the comment docs.

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@zhangthen zhangthen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prioritize initialization order for global transaction scanner
6 participants