Add unit tests for io.seata.common.util CompressUtil, DurationUtil, ReflectionUtil #1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eflectionUtil These tests were written using Diffblue Cover.
Codecov Report
@@ Coverage Diff @@
## develop #1232 +/- ##
=============================================
+ Coverage 43.94% 44.92% +0.98%
- Complexity 1451 1488 +37
=============================================
Files 253 253
Lines 10272 10272
Branches 1335 1335
=============================================
+ Hits 4514 4615 +101
+ Misses 5175 5070 -105
- Partials 583 587 +4
Continue to review full report at Codecov.
|
|
Good!Thanks! |
nick-tan
pushed a commit
to nick-tan/seata
that referenced
this pull request
Jul 12, 2019
…eflectionUtil (apache#1232) These tests were written using Diffblue Cover.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've analysed your codebase and noticed that
io.seata.common.util CompressUtil, DurationUtil, ReflectionUtilis not fully tested.I've written some tests for the methods in this class with the help of Diffblue Cover.
Hopefully, these tests will help you detect any regressions caused by future code changes. If you would find it useful to have additional tests written for this repository, I would be more than happy to look at other classes that you consider important.