support to delete undolog in back task #1235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1235 +/- ##
=============================================
- Coverage 48.6% 48.32% -0.29%
- Complexity 1645 1653 +8
=============================================
Files 331 333 +2
Lines 11535 11669 +134
Branches 1430 1448 +18
=============================================
+ Hits 5607 5639 +32
- Misses 5306 5401 +95
- Partials 622 629 +7
Continue to review full report at Codecov.
|
xingfudeshi
reviewed
Jun 24, 2019
slievrly
reviewed
Jun 27, 2019
| @Override | ||
| public AbstractTransactionResponse handle(RpcContext rpcContext) { | ||
| handler.handle(this); | ||
| return null; |
There was a problem hiding this comment.
why return null ?
async，we don't need reply
slievrly
reviewed
Jul 3, 2019
| byteBuffer.putShort((short)0); | ||
| } | ||
| //3.save days | ||
| byteBuffer.putInt(saveDays); |
| } | ||
| Map<String,Channel> channels = new HashMap(RM_CHANNELS.size()); | ||
| for (String resourceId : RM_CHANNELS.keySet()) { | ||
| Channel channel = tryOtherApp(RM_CHANNELS.get(resourceId), null); |
There was a problem hiding this comment.
why tryOtherApp？ tryOtherApp just get from RM_CHANNELS, loop is also getting from RM_CHANNELS and your map can only save one channel for a resource
There was a problem hiding this comment.
the method i have modified，when the param applitioncation is null，will find one avtive channel from all application.
| /** | ||
| * The Timeout retry delay. | ||
| */ | ||
| protected int transactionUndologDeleteDelay = CONFIG.getInt(ConfigurationKeys.TRANSACTION_UNDO_LOG_DELETE_DELAY, 24 * 60); |
There was a problem hiding this comment.
same with committingRetryDelay,asynCommittingRetryDelay,timeoutRetryDelay, default is SECONDS
…_del_backup # Conflicts: # core/src/main/java/io/seata/core/constants/ConfigurationKeys.java # core/src/main/java/io/seata/core/protocol/AbstractMessage.java
…scar into feature_del_backup
…_del_backup # Conflicts: # core/src/main/java/io/seata/core/rpc/ServerMessageSender.java # core/src/main/java/io/seata/core/rpc/netty/RmMessageListener.java # core/src/main/java/io/seata/core/rpc/netty/RpcServer.java
…scar into feature_del_backup
…_del_backup # Conflicts: # rm-datasource/src/main/java/io/seata/rm/datasource/undo/UndoLogManager.java
…scar into feature_del_backup
slievrly
reviewed
Jul 30, 2019
…scar into feature_del_backup
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
support to delete undolog in back task
Ⅱ. Does this pull request fix one issue?
a feature，some case the undolog will not delete ,the pr can avoid the undo_log table so big
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews