-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix:server start and handle remain branch session may cause NPE #1237
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1237 +/- ##
=============================================
- Coverage 44.94% 44.92% -0.03%
Complexity 1488 1488
=============================================
Files 253 253
Lines 10274 10279 +5
Branches 1335 1337 +2
=============================================
Hits 4618 4618
- Misses 5070 5072 +2
- Partials 586 589 +3
Continue to review full report at Codecov.
|
这个bug会导致RM注册上来的通道被关闭, 会有大量通道被关闭异常, 使用方非常难以判断真是问题
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
server start and handle remain branch session may cause it
Ⅱ. Does this pull request fix one issue?
byteBuffer.put((byte)this.branchType.ordinal());
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews