Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix:fix CME in ZK discovery implementation. #1239

Merged
merged 1 commit into from
Jun 26, 2019
Merged

bugfix:fix CME in ZK discovery implementation. #1239

merged 1 commit into from
Jun 26, 2019

Conversation

xingfudeshi
Copy link
Member

Ⅰ. Describe what this PR did

fix ConcurrentModificationException in Zookeeper discovery implementation.
Here, while traversing iZkChildListeners, new listener may be added, so CopyOnWriteArraylist must be used here to avoid CME.
image

image

Ⅱ. Does this pull request fix one issue?

fixex #1234

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@xingfudeshi xingfudeshi changed the title fix CME in ZK discovery implementation. bugfix:fix CME in ZK discovery implementation. Jun 25, 2019
@codecov-io
Copy link

codecov-io commented Jun 25, 2019

Codecov Report

Merging #1239 into develop will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1239      +/-   ##
=============================================
- Coverage      44.96%   44.93%   -0.03%     
  Complexity      1488     1488              
=============================================
  Files            253      253              
  Lines          10279    10279              
  Branches        1337     1337              
=============================================
- Hits            4622     4619       -3     
- Misses          5070     5072       +2     
- Partials         587      588       +1
Impacted Files Coverage Δ Complexity Δ
...very/registry/zk/ZookeeperRegisterServiceImpl.java 63.77% <100%> (ø) 24 <2> (ø) ⬇️
...server/store/file/FileTransactionStoreManager.java 46.34% <0%> (-1.05%) 19% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7039f91...370b60b. Read the comment docs.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@lovepoem lovepoem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lovepoem lovepoem merged commit 007ed0b into apache:develop Jun 26, 2019
@leizhiyuan leizhiyuan modified the milestone: 0.7.0 Jul 10, 2019
nick-tan pushed a commit to nick-tan/seata that referenced this pull request Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants