-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor metrics let it initialize by configuration #1245
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1245 +/- ##
=============================================
- Coverage 49.47% 45.36% -4.11%
+ Complexity 1651 1511 -140
=============================================
Files 326 256 -70
Lines 11439 10354 -1085
Branches 1415 1339 -76
=============================================
- Hits 5659 4697 -962
+ Misses 5153 5073 -80
+ Partials 627 584 -43
Continue to review full report at Codecov.
|
@zhengyangyong Please resolve conflicting files. |
Signed-off-by: zhengyangyong <yangyong.zheng@qq.com>
fbc5759
to
fb994ae
Compare
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: zhengyangyong <yangyong.zheng@qq.com>
Signed-off-by: zhengyangyong yangyong.zheng@qq.com
Ⅰ. Describe what this PR did
This pr refactor metrics in order to makes it works same as config or discovery loading mechanism.
now we can init it by config :
NOTICE: metrics is an optional feature so it will not configured by default, that means no metrics data is collecting and exporting by default even
seata-metrics-all
dependency had imported in server pom.For more information, please refer to https://github.com/zhengyangyong/seata/blob/metrics_tc_improve/metrics/README.md
Ⅱ. Does this pull request fix one issue?
#384
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
https://seata.io/zh-cn/docs/ops/operation.html (need update later)
Ⅴ. Special notes for reviews