Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix codecov for protobuf #1250

Merged
merged 1 commit into from
Jun 28, 2019
Merged

fix codecov for protobuf #1250

merged 1 commit into from
Jun 28, 2019

Conversation

leizhiyuan
Copy link
Contributor

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@leizhiyuan leizhiyuan added this to the 0.7.0 milestone Jun 27, 2019
@codecov-io
Copy link

codecov-io commented Jun 27, 2019

Codecov Report

Merging #1250 into develop will increase coverage by 13.78%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             develop    #1250       +/-   ##
==============================================
+ Coverage      35.65%   49.44%   +13.78%     
+ Complexity      2156     1651      -505     
==============================================
  Files            408      326       -82     
  Lines          21931    11439    -10492     
  Branches        3056     1415     -1641     
==============================================
- Hits            7820     5656     -2164     
+ Misses         13043     5155     -7888     
+ Partials        1068      628      -440
Impacted Files Coverage Δ Complexity Δ
...dec/protobuf/generated/RegisterRMRequestProto.java
.../protobuf/generated/BranchCommitResponseProto.java
.../io/seata/codec/protobuf/generated/ResultCode.java
...eata/codec/protobuf/generated/ResultCodeProto.java
...dec/protobuf/generated/GlobalRollbackResponse.java
...tobuf/generated/AbstractBranchEndRequestProto.java
...c/protobuf/generated/AbstractGlobalEndRequest.java
...ec/protobuf/generated/AbstractIdentifyRequest.java
...dec/protobuf/generated/RegisterTMRequestProto.java
...ata/codec/protobuf/generated/HeartbeatMessage.java
... and 72 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f49bb8d...9df722d. Read the comment docs.

Copy link
Member

@lovepoem lovepoem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@xingfudeshi xingfudeshi merged commit 735f409 into apache:develop Jun 28, 2019
@leizhiyuan leizhiyuan modified the milestone: 0.7.0 Jul 10, 2019
nick-tan pushed a commit to nick-tan/seata that referenced this pull request Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants