Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix find target class issue if scan the web scope bean such a… #1262

Merged
merged 5 commits into from
Jul 4, 2019

Conversation

zhuyoufeng
Copy link
Contributor

…s session scope ben

Ⅰ. Describe what this PR did

when a session scope bean (or other web scope bean) is called by SpringProxyUtils.findTargetClass, it will throw exception as the code "targetSource.getTarget()" will call 'org.springframework.beans.factory.config.Scope' to get bean instance.

Ⅱ. Does this pull request fix one issue?

#1168

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Jul 2, 2019

Codecov Report

Merging #1262 into develop will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1262   +/-   ##
==========================================
  Coverage      49.42%   49.42%           
  Complexity      1651     1651           
==========================================
  Files            326      326           
  Lines          11444    11444           
  Branches        1416     1416           
==========================================
  Hits            5656     5656           
  Misses          5158     5158           
  Partials         630      630
Impacted Files Coverage Δ Complexity Δ
...in/java/io/seata/spring/util/SpringProxyUtils.java 3.7% <0%> (ø) 3 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 612183b...e390fdb. Read the comment docs.

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!LGTM.

Copy link
Contributor

@CoffeeLatte007 CoffeeLatte007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xingfudeshi xingfudeshi merged commit c901bbe into apache:develop Jul 4, 2019
@leizhiyuan leizhiyuan modified the milestone: 0.7.0 Jul 10, 2019
nick-tan pushed a commit to nick-tan/seata that referenced this pull request Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants