Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configuration:update ignore and coverage #1264

Merged
merged 3 commits into from
Jul 4, 2019
Merged

configuration:update ignore and coverage #1264

merged 3 commits into from
Jul 4, 2019

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Jul 3, 2019

Signed-off-by: slievrly slievrly@163.com

Ⅰ. Describe what this PR did

configuration:update ignore and coverage

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
@codecov-io
Copy link

codecov-io commented Jul 3, 2019

Codecov Report

Merging #1264 into develop will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1264      +/-   ##
=============================================
- Coverage      49.45%   49.42%   -0.04%     
  Complexity      1651     1651              
=============================================
  Files            326      326              
  Lines          11444    11444              
  Branches        1416     1416              
=============================================
- Hits            5660     5656       -4     
- Misses          5156     5158       +2     
- Partials         628      630       +2
Impacted Files Coverage Δ Complexity Δ
...server/store/file/FileTransactionStoreManager.java 45.99% <0%> (-1.4%) 19% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21759b1...dc7d576. Read the comment docs.

Copy link
Contributor

@CoffeeLatte007 CoffeeLatte007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xingfudeshi xingfudeshi merged commit df4412c into apache:develop Jul 4, 2019
@leizhiyuan leizhiyuan modified the milestone: 0.7.0 Jul 10, 2019
nick-tan pushed a commit to nick-tan/seata that referenced this pull request Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants