Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: @GlobalLock get error with Response #1271

Merged
merged 1 commit into from
Jul 5, 2019
Merged

bugfix: @GlobalLock get error with Response #1271

merged 1 commit into from
Jul 5, 2019

Conversation

zjinlei
Copy link
Contributor

@zjinlei zjinlei commented Jul 5, 2019

Ⅰ. Describe what this PR did

fix issues 1224

Ⅱ. Does this pull request fix one issue?

fixes #1224

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Jul 5, 2019 •
edited

Codecov Report

Merging #1271 into develop will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1271      +/-   ##
=============================================
- Coverage      49.42%   49.41%   -0.01%     
  Complexity      1651     1651              
=============================================
  Files            326      326              
  Lines          11444    11445       +1     
  Branches        1416     1416              
=============================================
  Hits            5656     5656              
- Misses          5158     5159       +1     
  Partials         630      630
Impacted Files Coverage Δ Complexity Δ
...java/io/seata/rm/datasource/ConnectionContext.java 13.33% <0%> (-0.31%) 3 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df4412c...14a729c. Read the comment docs.

@slievrly slievrly changed the title bugfix issues 1224 bugfix: @GlobalLock get error with Response Jul 5, 2019
slievrly
slievrly approved these changes Jul 5, 2019
View reviewed changes
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sharajava
sharajava approved these changes Jul 5, 2019
View reviewed changes
Copy link
Contributor

@sharajava sharajava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's okey to me.

@slievrly slievrly merged commit ac856b2 into apache:develop Jul 5, 2019
@fescar-robot fescar-robot mentioned this pull request Jul 5, 2019
Closed
@zjinlei zjinlei deleted the develop-local branch July 8, 2019 01:58
@leizhiyuan leizhiyuan modified the milestone: 0.7.0 Jul 10, 2019
nick-tan pushed a commit to nick-tan/seata that referenced this pull request Jul 12, 2019
@zjinlei @nick-tan
bugfix issues 1224 (apache#1271)
7af90a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharajava sharajava sharajava approved these changes

@slievrly slievrly slievrly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.

Use @GlobalLock get error with Response[RuntimeException[null]]
5 participants
@zjinlei @codecov-io @sharajava @slievrly @leizhiyuan