Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1. optimization SQL join #1274

Merged
merged 2 commits into from
Jul 9, 2019
Merged

Conversation

andyqian
Copy link
Contributor

@andyqian andyqian commented Jul 5, 2019

Ⅰ. Describe what this PR did

  1. optimization SQL join

@codecov-io
Copy link

codecov-io commented Jul 5, 2019

Codecov Report

Merging #1274 into develop will decrease coverage by 0.11%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             develop   #1274      +/-   ##
============================================
- Coverage      49.41%   49.3%   -0.12%     
- Complexity      1651    1659       +8     
============================================
  Files            326     326              
  Lines          11448   11500      +52     
  Branches        1416    1423       +7     
============================================
+ Hits            5657    5670      +13     
- Misses          5161    5201      +40     
+ Partials         630     629       -1
Impacted Files Coverage Δ Complexity Δ
...va/io/seata/rm/datasource/exec/UpdateExecutor.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../rm/datasource/exec/BaseTransactionalExecutor.java 35.71% <0%> (+3.96%) 6 <0> (ø) ⬇️
...va/io/seata/rm/datasource/exec/InsertExecutor.java 57.97% <0%> (-0.86%) 14 <0> (ø)
...va/io/seata/rm/datasource/exec/DeleteExecutor.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...java/io/seata/spring/tcc/TccActionInterceptor.java 12.69% <0%> (-0.13%) 4% <0%> (+2%)
...a/rm/tcc/interceptor/ActionInterceptorHandler.java 27.27% <0%> (+1.89%) 13% <0%> (+6%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c5c6e6...212e225. Read the comment docs.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, java8 api: StringJoiner

@xingfudeshi xingfudeshi self-requested a review July 9, 2019 01:09
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xingfudeshi xingfudeshi merged commit da9a944 into apache:develop Jul 9, 2019
@andyqian andyqian deleted the optimiztion_develop branch July 9, 2019 14:09
@leizhiyuan leizhiyuan modified the milestone: 0.7.0 Jul 10, 2019
nick-tan pushed a commit to nick-tan/seata that referenced this pull request Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants