bugfix: pass txId into TCC interceptor #1278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # server/src/test/java/io/seata/server/coordinator/DefaultCoreTest.java
Codecov Report
@@ Coverage Diff @@
## develop #1278 +/- ##
=============================================
- Coverage 49.44% 49.41% -0.04%
Complexity 1651 1651
=============================================
Files 326 326
Lines 11449 11448 -1
Branches 1416 1416
=============================================
- Hits 5661 5657 -4
- Misses 5160 5161 +1
- Partials 628 630 +2
Continue to review full report at Codecov.
|
ujjboy
approved these changes
Jul 8, 2019
|
LGTM |
ujjboy
pushed a commit
to ujjboy/seata
that referenced
this pull request
Jul 8, 2019
leizhiyuan
pushed a commit
that referenced
this pull request
Jul 11, 2019
* New rpc protocol. * remove debug log, encode body of heartbeat. * bugfix: pass txId into TCC interceptor (#1278) * Fix same code as review. * Fix protobuf and add default conf.
nick-tan
pushed a commit
to nick-tan/seata
that referenced
this pull request
Jul 12, 2019
nick-tan
pushed a commit
to nick-tan/seata
that referenced
this pull request
Jul 12, 2019
* New rpc protocol. * remove debug log, encode body of heartbeat. * bugfix: pass txId into TCC interceptor (apache#1278) * Fix same code as review. * Fix protobuf and add default conf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1、Problem
The transaction context was cleared in PR #1195 , which cause the txId be null when regist branch record.
2. Solution
Save the txId when clear transaction context, and pass it into TCC interceptor.