Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seata-spring add dependency seata-codec-all #1297

Merged
merged 5 commits into from
Jul 15, 2019

Conversation

zjinlei
Copy link
Contributor

@zjinlei zjinlei commented Jul 13, 2019

Ⅰ. Describe what this PR did

Version 0.7 modified the protocol, rm needs to add jar seata-codec-all

Ⅱ. Does this pull request fix one issue?

fixes #1295

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@zjinlei zjinlei changed the title seata-spring add dependency seata-codec seata-spring add dependency seata-codec-all Jul 15, 2019
@codecov-io
Copy link

codecov-io commented Jul 15, 2019

Codecov Report

Merging #1297 into develop will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1297      +/-   ##
=============================================
+ Coverage      48.64%   48.65%   +<.01%     
  Complexity      1643     1643              
=============================================
  Files            332      332              
  Lines          11517    11517              
  Branches        1422     1422              
=============================================
+ Hits            5603     5604       +1     
  Misses          5293     5293              
+ Partials         621      620       -1
Impacted Files Coverage Δ Complexity Δ
...server/store/file/FileTransactionStoreManager.java 46.34% <0%> (+0.34%) 19% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7491188...1881e2e. Read the comment docs.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@lovepoem lovepoem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lovepoem lovepoem merged commit ad072fc into apache:develop Jul 15, 2019
@zjinlei zjinlei deleted the develop_local branch July 15, 2019 09:32
@wangliang181230 wangliang181230 modified the milestones: 0.7.*, 0.7.0, 1.5.0, 0.7.1 Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest relase 0.7.0 can not work
5 participants