Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add undo_log.sql and add database driver class config #1323

Merged
merged 5 commits into from
Jul 19, 2019

Conversation

vikenlove
Copy link
Contributor

@vikenlove vikenlove commented Jul 17, 2019

add a sql file when the first time to use seata . it is init to sql database and add database driver class name of config

@codecov-io
Copy link

codecov-io commented Jul 17, 2019

Codecov Report

Merging #1323 into develop will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1323      +/-   ##
=============================================
- Coverage      48.68%   48.65%   -0.03%     
  Complexity      1643     1643              
=============================================
  Files            332      332              
  Lines          11517    11521       +4     
  Branches        1423     1424       +1     
=============================================
- Hits            5607     5606       -1     
- Misses          5291     5295       +4     
- Partials         619      620       +1
Impacted Files Coverage Δ Complexity Δ
...ava/io/seata/core/constants/ConfigurationKeys.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...eata/server/store/db/DruidDataSourceGenerator.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...seata/server/store/db/DbcpDataSourceGenerator.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ata/core/store/db/AbstractDataSourceGenerator.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...server/store/file/FileTransactionStoreManager.java 47.03% <0%> (-0.35%) 19% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6d8e4d...904d37d. Read the comment docs.

@vikenlove vikenlove changed the title add undo_log.sql file to project of seata-server add undo_log.sql file to project of seata-server and add database driver class name of config Jul 17, 2019
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly changed the title add undo_log.sql file to project of seata-server and add database driver class name of config add undo_log.sql and add database driver class config Jul 18, 2019
@slievrly
Copy link
Member

fix #1320

@slievrly
Copy link
Member

In fact, the server side does not need the undolog table.

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xingfudeshi
Copy link
Member

In fact, the server side does not need the undolog table.

Yes.But it is a good idea to provide undo_log scripts on the server side. Because it will always be the same as the server version.

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i left a comment.

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit c4c5faf into apache:develop Jul 19, 2019
cmonkey pushed a commit to cmonkey/seata that referenced this pull request Jul 19, 2019
@wangliang181230 wangliang181230 added this to the 0.8.1 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants