bugfix: netty memory leak #1333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netty 4.1.24 LengthFieldBasedFrameDecoder LEAK
netty/netty#8140
Codecov Report
@@ Coverage Diff @@
## develop #1333 +/- ##
=============================================
+ Coverage 48.47% 48.63% +0.15%
Complexity 1645 1645
=============================================
Files 332 332
Lines 11503 11534 +31
Branches 1391 1428 +37
=============================================
+ Hits 5576 5609 +33
- Misses 5292 5302 +10
+ Partials 635 623 -12
Continue to review full report at Codecov.
|
1 task
lovepoem
reviewed
Jul 22, 2019
| ByteBuf frame = (ByteBuf) decoded; | ||
| return decodeFrame(frame); | ||
| }catch(Exception e){ | ||
| throw e; |
ujjboy
suggested changes
Jul 23, 2019
| }catch(Exception e){ | ||
| throw e; | ||
| }finally { | ||
| in.release(); |
There was a problem hiding this comment.
agree，in can be released in ByteToMessageDecoder.channelRead, but frame allocate in LengthFieldBasedFrameDecoder.
There was a problem hiding this comment.
change frame.release and add error logger
slievrly
changed the title
ujjboy
approved these changes
Jul 23, 2019
1 task
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fix #1304 #1318
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews