-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
batch insert support for non-self-inc primary keys #1337
batch insert support for non-self-inc primary keys #1337
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1337 +/- ##
=============================================
- Coverage 45.77% 45.75% -0.03%
- Complexity 1655 1660 +5
=============================================
Files 345 345
Lines 12345 12360 +15
Branches 1558 1535 -23
=============================================
+ Hits 5651 5655 +4
Misses 6057 6057
- Partials 637 648 +11
Continue to review full report at Codecov.
|
rm-datasource/src/main/java/io/seata/rm/datasource/exec/InsertExecutor.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in PS and non-PS mode, Insert into xx () values(),()
, works well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Unit Tests are passed. |
Ⅰ. Describe what this PR did
feature: batch insert support for non-self-incrementing primary keys
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
use test case BatchInsertExecutorTest.java
Ⅴ. Special notes for reviews