Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

batch insert support for non-self-inc primary keys #1337

Merged
merged 8 commits into from
Aug 3, 2019

Conversation

zjinlei
Copy link
Contributor

@zjinlei zjinlei commented Jul 23, 2019

Ⅰ. Describe what this PR did

feature: batch insert support for non-self-incrementing primary keys

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

use test case BatchInsertExecutorTest.java

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Jul 23, 2019

Codecov Report

Merging #1337 into develop will decrease coverage by 0.02%.
The diff coverage is 73.07%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1337      +/-   ##
=============================================
- Coverage      45.77%   45.75%   -0.03%     
- Complexity      1655     1660       +5     
=============================================
  Files            345      345              
  Lines          12345    12360      +15     
  Branches        1558     1535      -23     
=============================================
+ Hits            5651     5655       +4     
  Misses          6057     6057              
- Partials         637      648      +11
Impacted Files Coverage Δ Complexity Δ
...va/io/seata/rm/datasource/exec/InsertExecutor.java 66.27% <73.07%> (+7.12%) 20 <9> (+5) ⬆️
...obuf/convertor/BranchRegisterRequestConvertor.java 88% <0%> (-8%) 3% <0%> (ø)
...buf/convertor/GlobalLockQueryRequestConvertor.java 92.59% <0%> (-7.41%) 3% <0%> (ø)
...obuf/convertor/GlobalRollbackRequestConvertor.java 94.73% <0%> (-5.27%) 3% <0%> (ø)
...otobuf/convertor/GlobalStatusRequestConvertor.java 94.73% <0%> (-5.27%) 3% <0%> (ø)
...otobuf/convertor/GlobalCommitRequestConvertor.java 94.73% <0%> (-5.27%) 3% <0%> (ø)
...protobuf/convertor/RegisterTMRequestConvertor.java 95.45% <0%> (-4.55%) 3% <0%> (ø)
...protobuf/convertor/RegisterRMRequestConvertor.java 91.66% <0%> (-4.17%) 3% <0%> (ø)
...otobuf/convertor/BranchReportRequestConvertor.java 92.59% <0%> (-3.71%) 3% <0%> (ø)
...otobuf/convertor/BranchCommitRequestConvertor.java 96.42% <0%> (-3.58%) 3% <0%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a9efc4...d9d66f1. Read the comment docs.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in PS and non-PS mode, Insert into xx () values(),() , works well.

@slievrly slievrly changed the title batch insert support for non-self-incrementing primary keys batch insert support for non-self-inc primary keys Aug 2, 2019
@xingfudeshi xingfudeshi self-requested a review August 3, 2019 01:25
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xingfudeshi
Copy link
Member

Unit Tests are passed.

@xingfudeshi xingfudeshi merged commit 63afbd1 into apache:develop Aug 3, 2019
@zjinlei zjinlei deleted the feature/batchInsertNotAIUndo branch August 16, 2019 12:31
@wangliang181230 wangliang181230 added this to the 0.8.1 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants