Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: delete operation data rollback failed #1339

Merged
merged 4 commits into from
Jul 26, 2019

Conversation

zjinlei
Copy link
Contributor

@zjinlei zjinlei commented Jul 23, 2019

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #1319

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Jul 23, 2019

Codecov Report

Merging #1339 into develop will increase coverage by 0.04%.
The diff coverage is 71.42%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1339      +/-   ##
=============================================
+ Coverage      48.62%   48.66%   +0.04%     
- Complexity      1644     1645       +1     
=============================================
  Files            331      331              
  Lines          11535    11537       +2     
  Branches        1428     1429       +1     
=============================================
+ Hits            5609     5615       +6     
+ Misses          5303     5301       -2     
+ Partials         623      621       -2
Impacted Files Coverage Δ Complexity Δ
...va/io/seata/rm/datasource/undo/UndoLogManager.java 21.59% <0%> (ø) 9 <0> (ø) ⬇️
.../java/io/seata/rm/datasource/DataCompareUtils.java 73.13% <83.33%> (+0.82%) 25 <0> (+1) ⬆️
...server/store/file/FileTransactionStoreManager.java 47.38% <0%> (+1.39%) 19% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eecd110...689edc5. Read the comment docs.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@sharajava sharajava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okey to me

@slievrly slievrly merged commit 775564c into apache:develop Jul 26, 2019
@zjinlei zjinlei deleted the bugfix/deleteUndoFalied branch July 26, 2019 12:22
@wangliang181230 wangliang181230 added this to the 0.8.1 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete operation data rollback failed
5 participants