Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: ByteBuffer allocate len #1342

Merged
merged 2 commits into from
Jul 25, 2019
Merged

bugfix: ByteBuffer allocate len #1342

merged 2 commits into from
Jul 25, 2019

Conversation

slievrly
Copy link
Member

Signed-off-by: slievrly slievrly@163.com

Ⅰ. Describe what this PR did

bugfix: ByteBuffer allocate len

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
@codecov-io
Copy link

codecov-io commented Jul 23, 2019

Codecov Report

Merging #1342 into develop will not change coverage.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1342   +/-   ##
==========================================
  Coverage      48.65%   48.65%           
  Complexity      1643     1643           
==========================================
  Files            331      331           
  Lines          11533    11533           
  Branches        1428     1428           
==========================================
  Hits            5611     5611           
  Misses          5301     5301           
  Partials         621      621
Impacted Files Coverage Δ Complexity Δ
...src/main/java/io/seata/codec/seata/SeataCodec.java 80.64% <50%> (ø) 3 <2> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ea2ffc...e355f9d. Read the comment docs.

Copy link
Contributor

@ujjboy ujjboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@sharajava sharajava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its okey to me

@slievrly slievrly merged commit cce3246 into apache:develop Jul 25, 2019
@wangliang181230 wangliang181230 added this to the 0.8.1 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants