-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: ByteBuffer allocates a fixed length, which may cause BufferOverflowException #1344
Conversation
…OverflowException Signed-off-by: slievrly <slievrly@163.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Signed-off-by: slievrly <slievrly@163.com>
Codecov Report
@@ Coverage Diff @@
## develop #1344 +/- ##
=============================================
- Coverage 45.88% 45.51% -0.37%
+ Complexity 1672 1661 -11
=============================================
Files 345 345
Lines 12670 12665 -5
Branches 1598 1598
=============================================
- Hits 5813 5764 -49
- Misses 6201 6251 +50
+ Partials 656 650 -6
Continue to review full report at Codecov.
|
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getByteBuffer() should be removed later.
Signed-off-by: slievrly slievrly@163.com
Ⅰ. Describe what this PR did
bugfix: ByteBuffer allocates a fixed length, which may cause BufferOverflowException
Ⅱ. Does this pull request fix one issue?
fix #1336
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews