Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code clean and modify log level #1345

Merged
merged 2 commits into from
Jul 25, 2019
Merged

code clean and modify log level #1345

merged 2 commits into from
Jul 25, 2019

Conversation

slievrly
Copy link
Member

Signed-off-by: slievrly slievrly@163.com

Ⅰ. Describe what this PR did

modify log level and code clean

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
@codecov-io
Copy link

codecov-io commented Jul 24, 2019

Codecov Report

Merging #1345 into develop will increase coverage by 0.02%.
The diff coverage is 28.57%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1345      +/-   ##
=============================================
+ Coverage      48.63%   48.65%   +0.02%     
+ Complexity      1645     1643       -2     
=============================================
  Files            332      331       -1     
  Lines          11534    11533       -1     
  Branches        1428     1428              
=============================================
+ Hits            5609     5611       +2     
+ Misses          5302     5301       -1     
+ Partials         623      621       -2
Impacted Files Coverage Δ Complexity Δ
...ore/src/main/java/io/seata/core/lock/LockMode.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...rc/main/java/io/seata/core/codec/CodecFactory.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...rc/main/java/io/seata/core/rpc/ChannelManager.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../java/io/seata/server/coordinator/DefaultCore.java 59.64% <100%> (ø) 24 <0> (ø) ⬇️
.../java/io/seata/core/context/ContextCoreLoader.java 57.14% <100%> (ø) 1 <1> (ø) ⬇️
...atasource/undo/parser/ProtostuffUndoLogParser.java 42.85% <100%> (ø) 4 <1> (ø) ⬇️
...java/io/seata/rm/datasource/DataSourceManager.java 27.41% <12.5%> (ø) 7 <1> (ø) ⬇️
...n/java/io/seata/rm/datasource/ConnectionProxy.java 9.3% <14.28%> (-0.23%) 4 <0> (ø)
...server/store/file/FileTransactionStoreManager.java 47.38% <0%> (+1.39%) 19% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b7fe55...8dedd86. Read the comment docs.

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@sharajava sharajava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's okey to me.

@slievrly slievrly merged commit 3ea2ffc into apache:develop Jul 25, 2019
@wangliang181230 wangliang181230 added this to the 0.8.1 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants