Code Cleaning of Consul&Etcd implementations. #1357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1357 +/- ##
============================================
+ Coverage 35.3% 48.6% +13.3%
+ Complexity 2149 1645 -504
============================================
Files 413 331 -82
Lines 22032 11535 -10497
Branches 3071 1430 -1641
============================================
- Hits 7778 5607 -2171
+ Misses 13193 5306 -7887
+ Partials 1061 622 -439
Continue to review full report at Codecov.
|
ujjboy
suggested changes
Jul 29, 2019
config/seata-config-consul/src/main/java/io/seata/config/consul/ConsulConfiguration.java
Outdated
Show resolved
Hide resolved
config/seata-config-etcd3/src/main/java/io/seata/config/etcd3/EtcdConfiguration.java
Outdated
Show resolved
Hide resolved
...overy-consul/src/main/java/io/seata/discovery/registry/consul/ConsulRegistryServiceImpl.java
Show resolved
Hide resolved
...discovery-etcd3/src/main/java/io/seata/discovery/registry/etcd3/EtcdRegistryServiceImpl.java
Show resolved
Hide resolved
|
@ujjboy Thanks for your reviews.it's done,please check it. |
ujjboy
reviewed
Jul 30, 2019
config/seata-config-consul/src/main/java/io/seata/config/consul/ConsulConfiguration.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Code Cleaning of Consul&Etcd implementations.
Ⅱ. Does this pull request fix one issue?
Nil.
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews