schedule check table mata #1365

l81893521 · 2019-07-30T05:57:57Z

Ⅰ. Describe what this PR did

check the table meta regularly when rm client initialized.

Ⅱ. Does this pull request fix one issue?

#1350

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

…egularly

rm-datasource/src/main/java/io/seata/rm/datasource/sql/struct/TableMetaCache.java

rm-datasource/src/main/java/io/seata/rm/datasource/DataSourceProxy.java

rm-datasource/src/main/java/io/seata/rm/datasource/sql/struct/TableMetaCache.java

codecov-io · 2019-07-30T11:20:04Z

Codecov Report

Merging #1365 into develop will increase coverage by 0.12%.
The diff coverage is 43.75%.

@@              Coverage Diff              @@
##             develop    #1365      +/-   ##
=============================================
+ Coverage      45.87%   45.99%   +0.12%     
- Complexity      1660     1695      +35     
=============================================
  Files            345      345              
  Lines          12360    12486     +126     
  Branches        1562     1597      +35     
=============================================
+ Hits            5670     5743      +73     
- Misses          6057     6091      +34     
- Partials         633      652      +19

Impacted Files	Coverage Δ	Complexity Δ
...n/java/io/seata/rm/datasource/DataSourceProxy.java	`73.33% <100%> (+13.33%)`	`8 <2> (+2)`	⬆️
...a/io/seata/rm/datasource/sql/struct/TableMeta.java	`33.33% <35.29%> (+0.74%)`	`18 <3> (+3)`	⬆️
.../io/seata/rm/datasource/sql/struct/ColumnMeta.java	`66.66% <39.34%> (-29.77%)`	`47 <12> (+12)`
...a/io/seata/rm/datasource/sql/struct/IndexMeta.java	`64.51% <40%> (-22.99%)`	`24 <6> (+6)`
...seata/rm/datasource/sql/struct/TableMetaCache.java	`50.62% <60%> (+1.3%)`	`12 <3> (+3)`	⬆️
...very/registry/zk/ZookeeperRegisterServiceImpl.java	`64.56% <0%> (+0.78%)`	`24% <0%> (ø)`	⬇️
...io/seata/rm/datasource/AbstractStatementProxy.java	`14.75% <0%> (+4.91%)`	`4% <0%> (+2%)`	⬆️
...a/io/seata/rm/datasource/exec/ExecuteTemplate.java	`6.89% <0%> (+6.89%)`	`2% <0%> (+2%)`	⬆️
...o/seata/rm/datasource/AbstractConnectionProxy.java	`11.9% <0%> (+7.14%)`	`5% <0%> (+4%)`	⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df7772a...dfcf10d. Read the comment docs.

(cherry picked from commit 70c15e0)

…heck_table_mata_regularly

…egularly

rm-datasource/src/main/java/io/seata/rm/datasource/sql/struct/ColumnMeta.java

rm-datasource/src/main/java/io/seata/rm/datasource/sql/struct/IndexMeta.java

slievrly

The test found that when the table structure is not changed, it is judged as not equal

l81893521 · 2019-08-01T11:26:54Z

The test found that when the table structure is not changed, it is judged as not equal

Finally I found that when the table structure not change but the index meta cardinality will change

l81893521 · 2019-08-01T11:27:29Z

The test found that when the table structure is not changed, it is judged as not equal

I will provide some unit test these days.

…heck_table_mata_regularly # Conflicts: # rm-datasource/src/main/java/io/seata/rm/datasource/sql/struct/IndexMeta.java

xingfudeshi

LGTM.

slievrly

Verification passed.

slievrly · 2019-08-05T02:40:22Z

@l81893521 Cardinality is a statistic.

l81893521 and others added 17 commits April 29, 2019 17:23

optimize config loading when start up

ec6d35f

do not catch MissingException, change to Exception

99899a3

Merge branch 'develop' of github.com:l81893521/seata into my-develop

7f4c883

Merge branch 'develop' into develop

a0b4254

add warn log while could not found properties

309e658

Merge remote-tracking branch 'seata/develop' into my-develop

30efbd3

Merge remote-tracking branch 'origin/develop' into my-develop

7c0ac22

Merge branch 'develop' into develop

90bc335

Merge remote-tracking branch 'origin/develop' into my-develop

b3ca5cf

Merge remote-tracking branch 'origin/develop' into my-develop

3156f6f

Merge branch 'develop' of github.com:l81893521/seata into my-develop

7aa8165

Merge branch 'develop' into develop

88cffd3

Merge remote-tracking branch 'origin/develop' into my-develop

df1d266

Merge remote-tracking branch 'origin/develop' into my-develop

3f59d4a

Merge remote-tracking branch 'me/develop' into my-develop

240d405

Merge remote-tracking branch 'origin/develop' into check_table_meta_r…

344292e

…egularly

check table meta regularly

9b2c465

slievrly reviewed Jul 30, 2019

View reviewed changes

rm-datasource/src/main/java/io/seata/rm/datasource/sql/struct/TableMetaCache.java Outdated Show resolved Hide resolved

xingfudeshi self-requested a review July 30, 2019 06:47

xingfudeshi reviewed Jul 30, 2019

View reviewed changes

rm-datasource/src/main/java/io/seata/rm/datasource/DataSourceProxy.java Outdated Show resolved Hide resolved

xingfudeshi reviewed Jul 30, 2019

View reviewed changes

rm-datasource/src/main/java/io/seata/rm/datasource/sql/struct/TableMetaCache.java Outdated Show resolved Hide resolved

Merge branch 'develop' into check_table_mata_regularly

608c74c

l81893521 added 3 commits July 31, 2019 11:02

update table meta cache only table meta was changed

d7cd594

(cherry picked from commit 70c15e0)

Merge remote-tracking branch 'will/check_table_mata_regularly' into c…

93d2eae

…heck_table_mata_regularly

Merge remote-tracking branch 'origin/develop' into check_table_mata_r…

7cbeef6

…egularly

slievrly reviewed Jul 31, 2019

View reviewed changes

rm-datasource/src/main/java/io/seata/rm/datasource/sql/struct/ColumnMeta.java Outdated Show resolved Hide resolved

bug fix in equals method

5a9a3a3

slievrly reviewed Jul 31, 2019

View reviewed changes

rm-datasource/src/main/java/io/seata/rm/datasource/sql/struct/IndexMeta.java Show resolved Hide resolved

bug fix in equals method

b3a222d

xingfudeshi and others added 3 commits July 31, 2019 13:48

Merge branch 'develop' into check_table_mata_regularly

eda86a6

format the code

1c90b10

Merge branch 'develop' into check_table_mata_regularly

ad4ade5

slievrly reviewed Aug 1, 2019

View reviewed changes

l81893521 added 2 commits August 1, 2019 19:28

fix when table structure was not change but the index meta was not equal

b2ada7c

Merge remote-tracking branch 'will/check_table_mata_regularly' into c…

aa3b0b8

…heck_table_mata_regularly # Conflicts: # rm-datasource/src/main/java/io/seata/rm/datasource/sql/struct/IndexMeta.java

xingfudeshi approved these changes Aug 2, 2019

View reviewed changes

l81893521 and others added 5 commits August 2, 2019 23:47

add unit test

5f795bb

change error comment

85c9ed3

Merge branch 'develop' into check_table_mata_regularly

7510958

unit test bug fixed

a14115d

Merge branch 'develop' into check_table_mata_regularly

6ec1e18

slievrly changed the title ~~Check table mata regularly~~ schedule check table mata Aug 5, 2019

slievrly approved these changes Aug 5, 2019

View reviewed changes

Merge branch 'develop' into check_table_mata_regularly

dfcf10d

slievrly merged commit d209271 into apache:develop Aug 5, 2019

l81893521 deleted the check_table_mata_regularly branch August 8, 2019 12:43

fescar-robot mentioned this pull request Aug 9, 2019

[WeeklyReport] Weekly report for Seata 2019-8-2 to 2019-8-9 #1435

Closed

wangliang181230 added this to the 0.8.1 milestone Aug 9, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

schedule check table mata #1365

schedule check table mata #1365

l81893521 commented Jul 30, 2019

codecov-io commented Jul 30, 2019 •

edited

slievrly left a comment

l81893521 commented Aug 1, 2019

l81893521 commented Aug 1, 2019 •

edited

xingfudeshi left a comment

slievrly left a comment

slievrly commented Aug 5, 2019

schedule check table mata #1365

schedule check table mata #1365

Conversation

l81893521 commented Jul 30, 2019

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

codecov-io commented Jul 30, 2019 • edited

Codecov Report

slievrly left a comment

Choose a reason for hiding this comment

l81893521 commented Aug 1, 2019

l81893521 commented Aug 1, 2019 • edited

xingfudeshi left a comment

Choose a reason for hiding this comment

slievrly left a comment

Choose a reason for hiding this comment

slievrly commented Aug 5, 2019

codecov-io commented Jul 30, 2019 •

edited

l81893521 commented Aug 1, 2019 •

edited