-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: begin failed not release channel and throw exception #1370
Conversation
Signed-off-by: slievrly <slievrly@163.com>
Codecov Report
@@ Coverage Diff @@
## develop #1370 +/- ##
=============================================
+ Coverage 45.83% 45.96% +0.13%
Complexity 1695 1695
=============================================
Files 345 345
Lines 12486 12485 -1
Branches 1570 1596 +26
=============================================
+ Hits 5723 5739 +16
+ Misses 6094 6092 -2
+ Partials 669 654 -15
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: slievrly slievrly@163.com
Ⅰ. Describe what this PR did
bugfix: begin failed not release channel and throw exception
Ⅱ. Does this pull request fix one issue?
fix #1349
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews