Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: begin failed not release channel and throw exception #1370

Merged
merged 6 commits into from
Aug 5, 2019
Merged

bugfix: begin failed not release channel and throw exception #1370

merged 6 commits into from
Aug 5, 2019

Conversation

slievrly
Copy link
Member

Signed-off-by: slievrly slievrly@163.com

Ⅰ. Describe what this PR did

bugfix: begin failed not release channel and throw exception

Ⅱ. Does this pull request fix one issue?

fix #1349

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
@codecov-io
Copy link

codecov-io commented Jul 31, 2019

Codecov Report

Merging #1370 into develop will increase coverage by 0.13%.
The diff coverage is 33.33%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1370      +/-   ##
=============================================
+ Coverage      45.83%   45.96%   +0.13%     
  Complexity      1695     1695              
=============================================
  Files            345      345              
  Lines          12486    12485       -1     
  Branches        1570     1596      +26     
=============================================
+ Hits            5723     5739      +16     
+ Misses          6094     6092       -2     
+ Partials         669      654      -15
Impacted Files Coverage Δ Complexity Δ
...eata/core/rpc/netty/AbstractRpcRemotingClient.java 18.91% <ø> (+0.49%) 6 <0> (ø) ⬇️
...in/java/io/seata/tm/DefaultTransactionManager.java 4.34% <0%> (-0.42%) 1 <0> (ø)
...seata/core/exception/TransactionExceptionCode.java 82.14% <100%> (+0.66%) 2 <0> (ø) ⬇️
...rotobuf/convertor/RegisterTMResponseConvertor.java 84.84% <0%> (+3.03%) 3% <0%> (ø) ⬇️
...rotobuf/convertor/RegisterRMResponseConvertor.java 84.84% <0%> (+3.03%) 3% <0%> (ø) ⬇️
...otobuf/convertor/GlobalBeginResponseConvertor.java 96.96% <0%> (+3.03%) 3% <0%> (ø) ⬇️
...obuf/convertor/BranchRollbackRequestConvertor.java 96.42% <0%> (+3.57%) 3% <0%> (ø) ⬇️
...otobuf/convertor/BranchCommitRequestConvertor.java 100% <0%> (+3.57%) 3% <0%> (ø) ⬇️
...otobuf/convertor/BranchReportRequestConvertor.java 96.29% <0%> (+3.7%) 3% <0%> (ø) ⬇️
...protobuf/convertor/RegisterRMRequestConvertor.java 95.83% <0%> (+4.16%) 3% <0%> (ø) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df59704...17b13dc. Read the comment docs.

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link

@VainEffort VainEffort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 0cea70c into apache:develop Aug 5, 2019
@wangliang181230 wangliang181230 added this to the 0.8.1 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TM should check XID in phase of beginning
6 participants