-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: store.mode get configuration Inconsistent #1374
bugfix: store.mode get configuration Inconsistent #1374
Conversation
…/config/storemode/consistent
Codecov Report
@@ Coverage Diff @@
## develop #1374 +/- ##
============================================
+ Coverage 45.38% 45.5% +0.12%
- Complexity 1660 1661 +1
============================================
Files 345 345
Lines 12666 12667 +1
Branches 1571 1598 +27
============================================
+ Hits 5748 5764 +16
- Misses 6252 6253 +1
+ Partials 666 650 -16
Continue to review full report at Codecov.
|
When the configuration of the store.mode is inconsistent between the configuration of the startup parameters and the configuration center, the configuration of the LockManager is the configuration of the configuration.mode of the configuration center, and the configuration priority should be followed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okey to me
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fix #1373 (Cooperate with pr 1379)
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews