Fixed issue where clusterAddressMap did not remove this instance after the instance was offline #1378

wanghuizuo · 2019-08-01T05:21:52Z

Ⅰ. Describe what this PR did

Fixed issue where clusterAddressMap did not remove this instance after the instance was offline.
remove EurekaRegistryException, because EurekaRegistryException is RuntimeException.
add log.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

* 如果clusterAddressMap存在key App1 * Eureka返回的Apps是App2, App3, refreshCluster后clusterAddressMap还会存在App1 * * 场景： * Eureka注册App1,App2，refreshCluster后clusterAddressMap存在App1,App2 * App1下线，Eureka返回App2，refreshCluster后clusterAddressMap存在App1,App2

codecov-io · 2019-08-01T05:27:21Z

Codecov Report

Merging #1378 into develop will increase coverage by 0.01%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #1378      +/-   ##
=============================================
+ Coverage       45.8%   45.82%   +0.01%     
  Complexity      1655     1655              
=============================================
  Files            343      343              
  Lines          12337    12337              
  Branches        1556     1556              
=============================================
+ Hits            5651     5653       +2     
+ Misses          6051     6050       -1     
+ Partials         635      634       -1

Impacted Files	Coverage Δ	Complexity Δ
...server/store/file/FileTransactionStoreManager.java	`47.38% <0%> (+0.34%)`	`19% <0%> (ø)`	⬇️
...very/registry/zk/ZookeeperRegisterServiceImpl.java	`64.56% <0%> (+0.78%)`	`24% <0%> (ø)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 684d5d0...1a25942. Read the comment docs.

...overy-eureka/src/main/java/io/seata/discovery/registry/eureka/EurekaRegistryServiceImpl.java

xingfudeshi

Thanks.i left some reviews.

...overy-eureka/src/main/java/io/seata/discovery/registry/eureka/EurekaRegistryServiceImpl.java

1. do no import *. 2. LOGGER.error("Eureka event listener refreshCluster error:{}", e.getMessage(), e); 3. fix map capacity 4. set use default capacity

1. if instances is empty do not put

slievrly

LGTM

xingfudeshi

LGTM.