Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: get SessionManager error when rollback retry timeout #1385

Merged
merged 2 commits into from
Aug 2, 2019

Conversation

zjinlei
Copy link
Contributor

@zjinlei zjinlei commented Aug 1, 2019

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei changed the title bugfix: code error bugfix: get SessionManager error when rollback retry timeout Aug 1, 2019
@codecov-io
Copy link

codecov-io commented Aug 1, 2019

Codecov Report

Merging #1385 into develop will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1385   +/-   ##
==========================================
  Coverage      45.78%   45.78%           
  Complexity      1655     1655           
==========================================
  Files            343      343           
  Lines          12337    12337           
  Branches        1556     1556           
==========================================
  Hits            5648     5648           
  Misses          6053     6053           
  Partials         636      636
Impacted Files Coverage Δ Complexity Δ
...o/seata/server/coordinator/DefaultCoordinator.java 53.21% <0%> (ø) 28 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1342bc...da12ffe. Read the comment docs.

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xingfudeshi xingfudeshi merged commit 84fd61c into apache:develop Aug 2, 2019
@zjinlei zjinlei deleted the bugfix/codeerror branch August 2, 2019 10:34
@wangliang181230 wangliang181230 added this to the 0.8.1 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants