Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Oracle prompt code to the else code block #1389

Merged
merged 3 commits into from
Aug 2, 2019

Conversation

itxingqing
Copy link
Contributor

Ⅰ. Describe what this PR did

修改else块中的提示代码,增加支持Oralce的提示

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

从Just support MySQL by now!,改为Just support MySQL And Oracle by now!,避免没看源代码的同学,运行看到提示时,造成误解!
修改else块中的提示代码,增加支持Oralce的提示,避免没有看到代码,运行时看到提示信息,造成误解
@slievrly slievrly changed the title adding Oracle prompt code to the else code block add Oracle prompt code to the else code block Aug 2, 2019
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented Aug 2, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@84fd61c). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1389   +/-   ##
==========================================
  Coverage           ?   45.81%           
  Complexity         ?     1655           
==========================================
  Files              ?      343           
  Lines              ?    12337           
  Branches           ?     1556           
==========================================
  Hits               ?     5652           
  Misses             ?     6051           
  Partials           ?      634
Impacted Files Coverage Δ Complexity Δ
.../io/seata/rm/datasource/sql/SQLVisitorFactory.java 21.42% <0%> (ø) 2 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84fd61c...e1b0cf6. Read the comment docs.

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@slievrly slievrly merged commit 329d12c into apache:develop Aug 2, 2019
@wangliang181230 wangliang181230 added this to the 0.8.1 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants