Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: check null channel #1395

Merged
merged 2 commits into from
Aug 5, 2019
Merged

bugfix: check null channel #1395

merged 2 commits into from
Aug 5, 2019

Conversation

lightClouds917
Copy link
Contributor

@lightClouds917 lightClouds917 commented Aug 3, 2019

Ⅰ. Describe what this PR did
if (null == rmChannel || rmChannel.isActive()) { return rmChannel; }
Our goal is to get a active rmChannel,So when null == rmChannel ,we can not return,Otherwise it will be called in a loop.

Ⅱ. Does this pull request fix one issue?

I dont know.

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

review maybe

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Aug 3, 2019

Codecov Report

Merging #1395 into develop will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1395   +/-   ##
==========================================
  Coverage      45.97%   45.97%           
  Complexity      1695     1695           
==========================================
  Files            345      345           
  Lines          12486    12486           
  Branches        1597     1597           
==========================================
  Hits            5741     5741           
  Misses          6092     6092           
  Partials         653      653
Impacted Files Coverage Δ Complexity Δ
...eata/core/rpc/netty/NettyClientChannelManager.java 70.53% <0%> (ø) 22 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b9a0fa...d617feb. Read the comment docs.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly changed the title NettyClientChannelManager#getExistAliveChannel() check null channel bugfix:NettyClientChannelManager#getExistAliveChannel() check null channel Aug 5, 2019
@slievrly slievrly changed the title bugfix:NettyClientChannelManager#getExistAliveChannel() check null channel bugfix: check null channel Aug 5, 2019
@slievrly slievrly merged commit 7c29eb0 into apache:develop Aug 5, 2019
@wangliang181230 wangliang181230 added this to the 0.8.1 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants