New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix:rm channel register null resource #1401
Conversation
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Codecov Report
@@ Coverage Diff @@
## develop #1401 +/- ##
=============================================
+ Coverage 50.05% 50.06% +0.01%
Complexity 2130 2130
=============================================
Files 411 412 +1
Lines 14209 14218 +9
Branches 1715 1715
=============================================
+ Hits 7112 7118 +6
- Misses 6407 6411 +4
+ Partials 690 689 -1
Continue to review full report at Codecov.
|
please resolve conflicts |
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com> # Conflicts: # core/src/main/java/io/seata/core/rpc/netty/RmRpcClient.java # rm-datasource/src/main/java/io/seata/rm/datasource/DataSourceManager.java
Signed-off-by: slievrly <slievrly@163.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* 'develop' of https://github.com/seata/seata: test: enhance test coverage of seata common (apache#1755) security: upgrade jackson to avoid security vulnerabilities (apache#1756) bugfix:rm channel register null resource (apache#1401) bugfix:fix memory lock is not released due to hash conflict (apache#1751) optimize:use raw types instead of boxing types (apache#1747) change get charset (apache#1707) fix undo support oracle table meta cache (apache#1749) bugfix: fix use 'in' and 'between' in where condition for Oracle and Mysql (apache#1699) optimize:add some server's jvm parameters (apache#1738) Saga implementation base on state machine (apache#1608) optimize:inner class may be static (apache#1706) feature: retry when tm commit or rollback failed (apache#1739) optimize: abstract common undolog manager method (apache#1712) bugfix: when tm commit or rollback failed,xid need to be clean (apache#1735) optimize: eliminate the possibility of allocating too much direct memory (apache#1657) Based on Java 5 optimization (apache#1705) bugfix: oracle batch insert error (apache#1729) # Conflicts: # pom.xml
hi @slievrly , this commit leads to the springboot-tcc-sample keeps blocking when run the i found the reason leads to blocking is that should i modify the springboot-tcc-sample somewhere to adapt this ? thanks |
Signed-off-by: slievrly slievrly@163.com
Ⅰ. Describe what this PR did
bugfix:rm channel register null resource
Ⅱ. Does this pull request fix one issue?
ref #1359
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews