Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize:optimize BranchStatus annotation #1404

Merged
merged 5 commits into from
Aug 7, 2019
Merged

Optimize:optimize BranchStatus annotation #1404

merged 5 commits into from
Aug 7, 2019

Conversation

lightClouds917
Copy link
Contributor

Ⅰ. Describe what this PR did
Optimize BranchStatus.java annotation,the annotation is very messy.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Aug 5, 2019

Codecov Report

Merging #1404 into develop will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1404      +/-   ##
=============================================
- Coverage      45.98%   45.97%   -0.02%     
  Complexity      1672     1672              
=============================================
  Files            345      345              
  Lines          12635    12636       +1     
  Branches        1596     1596              
=============================================
- Hits            5810     5809       -1     
- Misses          6168     6169       +1     
- Partials         657      658       +1
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/io/seata/core/model/BranchStatus.java 100% <ø> (ø) 7 <0> (ø) ⬇️
.../java/io/seata/server/coordinator/DefaultCore.java 59.3% <0%> (-0.35%) 24 <0> (ø)
...server/store/file/FileTransactionStoreManager.java 45.99% <0%> (-0.35%) 19% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e57b6ca...6004ffe. Read the comment docs.

@lightClouds917
Copy link
Contributor Author

lightClouds917 commented Aug 5, 2019

the second commit is to add log for issue #1400

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@slievrly slievrly merged commit 60ab1ce into apache:develop Aug 7, 2019
@wangliang181230 wangliang181230 added this to the 0.8.1 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants