-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize:optimize BranchStatus annotation #1404
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1404 +/- ##
=============================================
- Coverage 45.98% 45.97% -0.02%
Complexity 1672 1672
=============================================
Files 345 345
Lines 12635 12636 +1
Branches 1596 1596
=============================================
- Hits 5810 5809 -1
- Misses 6168 6169 +1
- Partials 657 658 +1
Continue to review full report at Codecov.
|
the second commit is to add log for issue #1400 |
server/src/main/java/io/seata/server/coordinator/DefaultCore.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/seata/server/coordinator/DefaultCore.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Ⅰ. Describe what this PR did
Optimize BranchStatus.java annotation,the annotation is very messy.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews