Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable unstable unit tests #1407

Merged
merged 1 commit into from
Aug 6, 2019
Merged

disable unstable unit tests #1407

merged 1 commit into from
Aug 6, 2019

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Aug 6, 2019

Signed-off-by: slievrly slievrly@163.com

Ⅰ. Describe what this PR did

disable unstable unit tests

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
@codecov-io
Copy link

codecov-io commented Aug 6, 2019

Codecov Report

Merging #1407 into develop will decrease coverage by 0.64%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1407      +/-   ##
=============================================
- Coverage      45.99%   45.35%   -0.65%     
+ Complexity      1695     1672      -23     
=============================================
  Files            345      345              
  Lines          12485    12485              
  Branches        1596     1596              
=============================================
- Hits            5742     5662      -80     
- Misses          6090     6166      +76     
- Partials         653      657       +4
Impacted Files Coverage Δ Complexity Δ
...java/io/seata/server/metrics/MeterIdConstants.java 0% <0%> (-96.56%) 0% <0%> (-1%)
...n/java/io/seata/server/metrics/MetricsManager.java 0% <0%> (-76.93%) 0% <0%> (-5%)
...ava/io/seata/server/metrics/MetricsSubscriber.java 0% <0%> (-73.53%) 0% <0%> (-6%)
...in/java/io/seata/server/session/GlobalSession.java 79.8% <0%> (-4.81%) 59% <0%> (-8%)
...o/seata/server/coordinator/DefaultCoordinator.java 50% <0%> (-3.22%) 25% <0%> (-3%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5f4de4...5614a6d. Read the comment docs.

Copy link
Contributor

@sharajava sharajava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okey to me

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xingfudeshi xingfudeshi merged commit c14ba50 into apache:develop Aug 6, 2019
@wangliang181230 wangliang181230 added this to the 0.8.1 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants