-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix:map.toString error #1409
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved this pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okey to me
Codecov Report
@@ Coverage Diff @@
## develop #1409 +/- ##
===========================================
- Coverage 45.5% 45.4% -0.1%
+ Complexity 1661 1660 -1
===========================================
Files 345 345
Lines 12665 12666 +1
Branches 1598 1571 -27
===========================================
- Hits 5763 5751 -12
+ Misses 6251 6250 -1
- Partials 651 665 +14
Continue to review full report at Codecov.
|
Ⅰ. Describe what this PR did
StringUtils.toString() method output error when instance of map
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews