Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix:map.toString error #1409

Merged
merged 3 commits into from
Aug 8, 2019
Merged

bugfix:map.toString error #1409

merged 3 commits into from
Aug 8, 2019

Conversation

kongwang
Copy link

@kongwang kongwang commented Aug 6, 2019

Ⅰ. Describe what this PR did

StringUtils.toString() method output error when instance of map

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@Haiyoung Haiyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved this pull request.

Copy link
Contributor

@sharajava sharajava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okey to me

@codecov-io
Copy link

codecov-io commented Aug 7, 2019

Codecov Report

Merging #1409 into develop will decrease coverage by 0.09%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##             develop   #1409     +/-   ##
===========================================
- Coverage       45.5%   45.4%   -0.1%     
+ Complexity      1661    1660      -1     
===========================================
  Files            345     345             
  Lines          12665   12666      +1     
  Branches        1598    1571     -27     
===========================================
- Hits            5763    5751     -12     
+ Misses          6251    6250      -1     
- Partials         651     665     +14
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/io/seata/common/util/StringUtils.java 26.25% <0%> (-0.34%) 15 <0> (ø)
...obuf/convertor/BranchRegisterRequestConvertor.java 88% <0%> (-8%) 3% <0%> (ø)
...buf/convertor/GlobalLockQueryRequestConvertor.java 92.59% <0%> (-7.41%) 3% <0%> (ø)
...obuf/convertor/GlobalRollbackRequestConvertor.java 94.73% <0%> (-5.27%) 3% <0%> (ø)
...otobuf/convertor/GlobalStatusRequestConvertor.java 94.73% <0%> (-5.27%) 3% <0%> (ø)
...otobuf/convertor/GlobalCommitRequestConvertor.java 94.73% <0%> (-5.27%) 3% <0%> (ø)
...protobuf/convertor/RegisterTMRequestConvertor.java 95.45% <0%> (-4.55%) 3% <0%> (ø)
...protobuf/convertor/RegisterRMRequestConvertor.java 91.66% <0%> (-4.17%) 3% <0%> (ø)
...otobuf/convertor/BranchReportRequestConvertor.java 92.59% <0%> (-3.71%) 3% <0%> (ø)
...otobuf/convertor/BranchCommitRequestConvertor.java 96.42% <0%> (-3.58%) 3% <0%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 421e9ea...c56aa9b. Read the comment docs.

@slievrly slievrly merged commit ab6bece into apache:develop Aug 8, 2019
@wangliang181230 wangliang181230 added this to the 0.8.1 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants