Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some javadoc comments #1416

Merged
merged 24 commits into from
Aug 8, 2019
Merged

fix some javadoc comments #1416

merged 24 commits into from
Aug 8, 2019

Conversation

lukairui
Copy link
Contributor

@lukairui lukairui commented Aug 7, 2019

Ⅰ. Describe what this PR did

    Some adjustments on the comments.

Ⅱ. Does this pull request fix one issue?

    No.

Ⅲ. Why don't you add test cases (unit test/integration test)?

    That is not necessary.

Ⅳ. Describe how to verify it

    em.....

Ⅴ. Special notes for reviews

    Nothing.

Some adjustments on the comments
Some adjustments on the comments
Some adjustments on the comments
Some adjustments on the comments
Some adjustments on the comments
Some adjustments on the comments
Some adjustments on the comments
Some adjustments on the comments
Some adjustments on the comments
Some adjustments on the comments
Some adjustments on the comments
Some adjustments on the comments
Some adjustments on the comments
Some adjustments on the comments
Some adjustments on the comments
Some adjustments on the comments
Some adjustments on the comments
Some adjustments on the comments
Some adjustments on the comments
Some adjustments on the comments
Some adjustments on the comments
@codecov-io
Copy link

codecov-io commented Aug 7, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@ab6bece). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             develop   #1416   +/-   ##
=========================================
  Coverage           ?   45.5%           
  Complexity         ?    1661           
=========================================
  Files              ?     345           
  Lines              ?   12666           
  Branches           ?    1598           
=========================================
  Hits               ?    5764           
  Misses             ?    6252           
  Partials           ?     650
Impacted Files Coverage Δ Complexity Δ
...e/src/main/java/io/seata/core/store/StoreMode.java 0% <ø> (ø) 0 <0> (?)
.../src/main/java/io/seata/core/constants/DBType.java 73.33% <ø> (ø) 1 <0> (?)
...ain/java/io/seata/core/store/db/LockStoreSqls.java 25% <ø> (ø) 3 <0> (?)
core/src/main/java/io/seata/core/lock/RowLock.java 0% <ø> (ø) 0 <0> (?)
core/src/main/java/io/seata/core/store/LockDO.java 95.83% <ø> (ø) 15 <0> (?)
.../java/io/seata/core/store/BranchTransactionDO.java 92.3% <ø> (ø) 23 <0> (?)
.../main/java/io/seata/core/protocol/MessageType.java 0% <ø> (ø) 0 <0> (?)
...main/java/io/seata/core/store/db/LogStoreSqls.java 23.25% <ø> (ø) 10 <0> (?)
...ata/core/store/db/AbstractDataSourceGenerator.java 0% <ø> (ø) 0 <0> (?)
.../java/io/seata/core/store/GlobalTransactionDO.java 97.14% <ø> (ø) 23 <0> (?)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab6bece...b668c6b. Read the comment docs.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly changed the title Some adjustments on the comments fix some javadoc comments Aug 8, 2019
@slievrly slievrly merged commit a28dc4e into apache:develop Aug 8, 2019
@wangliang181230 wangliang181230 added this to the 0.8.1 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants