-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: if the connection is autocommit=false will cause fail to delete #1419
Conversation
Signed-off-by: slievrly <slievrly@163.com>
Codecov Report
@@ Coverage Diff @@
## develop #1419 +/- ##
=============================================
- Coverage 45.87% 45.87% -0.01%
Complexity 1672 1672
=============================================
Files 345 345
Lines 12662 12669 +7
Branches 1596 1598 +2
=============================================
+ Hits 5809 5812 +3
- Misses 6195 6200 +5
+ Partials 658 657 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okey to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your optimization,i have one question
Signed-off-by: slievrly <slievrly@163.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it’s ok to me
Signed-off-by: slievrly slievrly@163.com
Ⅰ. Describe what this PR did
bugfix: if the connection is autocommit=false will cause fail to delete
Ⅱ. Does this pull request fix one issue?
fix #1420
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews