Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: if the connection is autocommit=false will cause fail to delete #1419

Merged
merged 3 commits into from
Aug 8, 2019
Merged

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Aug 7, 2019

Signed-off-by: slievrly slievrly@163.com

Ⅰ. Describe what this PR did

bugfix: if the connection is autocommit=false will cause fail to delete

Ⅱ. Does this pull request fix one issue?

fix #1420

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Aug 7, 2019

Codecov Report

Merging #1419 into develop will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1419      +/-   ##
=============================================
- Coverage      45.87%   45.87%   -0.01%     
  Complexity      1672     1672              
=============================================
  Files            345      345              
  Lines          12662    12669       +7     
  Branches        1596     1598       +2     
=============================================
+ Hits            5809     5812       +3     
- Misses          6195     6200       +5     
+ Partials         658      657       -1
Impacted Files Coverage Δ Complexity Δ
...asource/src/main/java/io/seata/rm/RMHandlerAT.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...server/store/file/FileTransactionStoreManager.java 47.03% <0%> (+1.04%) 19% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ba7f46...ace300a. Read the comment docs.

Copy link
Contributor

@sharajava sharajava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okey to me

Copy link
Contributor

@github-ygy github-ygy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your optimization,i have one question

rm-datasource/src/main/java/io/seata/rm/RMHandlerAT.java Outdated Show resolved Hide resolved
Copy link
Contributor

@github-ygy github-ygy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it’s ok to me

@slievrly slievrly merged commit 1dd65b7 into apache:develop Aug 8, 2019
@wangliang181230 wangliang181230 added this to the 0.8.1 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

if the connection is autocommit=false will cause fail to delete
5 participants