Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo #1425

Merged
merged 3 commits into from
Aug 9, 2019
Merged

fix typo #1425

merged 3 commits into from
Aug 9, 2019

Conversation

Arlmls
Copy link
Contributor

@Arlmls Arlmls commented Aug 8, 2019

Ⅰ. Describe what this PR did

Misspelling of words

Ⅱ. Does this pull request fix one issue?

no

Ⅲ. Why don't you add test cases (unit test/integration test)?

don’t need

Ⅳ. Describe how to verify it

no

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Aug 8, 2019

Codecov Report

Merging #1425 into develop will increase coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1425      +/-   ##
=============================================
+ Coverage       45.4%   45.43%   +0.02%     
  Complexity      1662     1662              
=============================================
  Files            345      345              
  Lines          12692    12692              
  Branches        1608     1608              
=============================================
+ Hits            5763     5766       +3     
+ Misses          6281     6279       -2     
+ Partials         648      647       -1
Impacted Files Coverage Δ Complexity Δ
...covery/registry/etcd3/EtcdRegistryServiceImpl.java 12.29% <0%> (ø) 3 <0> (ø) ⬇️
...server/store/file/FileTransactionStoreManager.java 47.03% <0%> (+1.04%) 19% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59c6407...c6e2811. Read the comment docs.

@slievrly slievrly changed the title M Regestry modify Registry fix typo Aug 8, 2019
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ujjboy ujjboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ujjboy ujjboy merged commit d242977 into apache:develop Aug 9, 2019
@wangliang181230 wangliang181230 added this to the 0.8.1 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants