Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix syntax error #1426

Merged
merged 2 commits into from
Aug 9, 2019
Merged

fix syntax error #1426

merged 2 commits into from
Aug 9, 2019

Conversation

wangjin
Copy link
Contributor

@wangjin wangjin commented Aug 8, 2019

Ⅰ. Describe what this PR did

fix syntax error

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented Aug 8, 2019

Codecov Report

Merging #1426 into develop will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             develop   #1426      +/-   ##
============================================
- Coverage      45.41%   45.4%   -0.01%     
  Complexity      1662    1662              
============================================
  Files            345     345              
  Lines          12692   12692              
  Branches        1608    1608              
============================================
- Hits            5764    5763       -1     
- Misses          6280    6281       +1     
  Partials         648     648
Impacted Files Coverage Δ Complexity Δ
...very/registry/zk/ZookeeperRegisterServiceImpl.java 63.77% <0%> (-0.79%) 24% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d242977...0e17b2a. Read the comment docs.

@l81893521
Copy link
Contributor

LGTM

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ujjboy ujjboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ujjboy ujjboy merged commit 4efbd27 into apache:develop Aug 9, 2019
@wangliang181230 wangliang181230 added this to the 0.8.1 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants