Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused imports #1429

Merged
merged 4 commits into from
Aug 9, 2019
Merged

remove unused imports #1429

merged 4 commits into from
Aug 9, 2019

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Aug 9, 2019

Signed-off-by: slievrly slievrly@163.com

Ⅰ. Describe what this PR did

remove unused imports

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

slievrly and others added 2 commits August 9, 2019 11:13
Signed-off-by: slievrly <slievrly@163.com>
@codecov-io
Copy link

codecov-io commented Aug 9, 2019

Codecov Report

Merging #1429 into develop will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1429      +/-   ##
=============================================
+ Coverage      45.27%   45.42%   +0.15%     
  Complexity      1662     1662              
=============================================
  Files            345      345              
  Lines          12673    12699      +26     
  Branches        1571     1608      +37     
=============================================
+ Hits            5738     5769      +31     
- Misses          6277     6282       +5     
+ Partials         658      648      -10
Impacted Files Coverage Δ Complexity Δ
...rm/datasource/sql/struct/TableMetaCacheOracle.java 0% <ø> (ø) 0 <0> (ø) ⬇️
.../core/protocol/transaction/GlobalBeginRequest.java 64.7% <ø> (ø) 3 <0> (ø) ⬇️
...ource/sql/druid/oracle/OracleInsertRecognizer.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...n/java/io/seata/server/lock/db/DataBaseLocker.java 30.43% <ø> (ø) 5 <0> (ø) ⬇️
...java/io/seata/core/protocol/RegisterRMRequest.java 100% <ø> (ø) 6 <0> (ø) ⬇️
...java/io/seata/rm/datasource/DataSourceManager.java 25.75% <ø> (ø) 7 <0> (ø) ⬇️
...protocol/transaction/AbstractBranchEndRequest.java 84.84% <ø> (ø) 7 <0> (ø) ⬇️
...ource/sql/druid/oracle/OracleDeleteRecognizer.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...seata/rm/datasource/sql/struct/TableMetaCache.java 50.62% <ø> (ø) 12 <0> (ø) ⬇️
...in/java/io/seata/server/session/GlobalSession.java 79.8% <0%> (-1.48%) 59% <0%> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7103e54...f1b084a. Read the comment docs.

Copy link
Contributor

@ujjboy ujjboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xingfudeshi xingfudeshi merged commit bfbde05 into apache:develop Aug 9, 2019
@wangliang181230 wangliang181230 added this to the 0.8.1 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants