feature: support kryo codec #1437
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1437 +/- ##
=============================================
+ Coverage 46.38% 46.72% +0.33%
- Complexity 1717 1730 +13
=============================================
Files 350 353 +3
Lines 12855 12949 +94
Branches 1619 1619
=============================================
+ Hits 5963 6050 +87
- Misses 6242 6246 +4
- Partials 650 653 +3
Continue to review full report at Codecov.
|
|
Duplicate with #1418, can you close one PR? |
|
@jsbxyyx sorry, I didn't notice that. |
| KryoSerializer kryoSerializer = KryoSerializerFactory.getInstance().get(); | ||
| try { | ||
| T t = kryoSerializer.deserialize(bytes); | ||
| return t; |
There was a problem hiding this comment.
return kryoSerializer.serialize(t);
| KryoSerializer kryoSerializer = KryoSerializerFactory.getInstance().get(); | ||
| try { | ||
| byte[] bytes = kryoSerializer.serialize(t); | ||
| return bytes; |
There was a problem hiding this comment.
return kryoSerializer.serialize(t);
| ByteArrayOutputStream baos = new ByteArrayOutputStream(); | ||
| Output output = new Output(baos); | ||
| kryo.writeClassAndObject(output, t); | ||
| output.close(); |
There was a problem hiding this comment.
close() inner call flush()
| public <T> T deserialize(byte[] bytes) { | ||
| ByteArrayInputStream bais = new ByteArrayInputStream(bytes); | ||
| Input input = new Input(bais); | ||
| input.close(); |
There was a problem hiding this comment.
Close is called before kryo.readClassAndObject(input);Is there a problem?
There was a problem hiding this comment.
FileInputStream close and ByteArrayInputStream close implements different, here not problem.
protocol kryo serializer