Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify operation of map #1444

Merged
merged 6 commits into from
Aug 21, 2019

Conversation

tswstarplanet
Copy link
Contributor

Ⅰ. Describe what this PR did

Simplify some redundant code of operation of map

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Aug 11, 2019

Codecov Report

Merging #1444 into develop will decrease coverage by 0.69%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##             develop   #1444     +/-   ##
===========================================
- Coverage      46.39%   45.7%   -0.7%     
+ Complexity      1691    1664     -27     
===========================================
  Files            347     345      -2     
  Lines          12713   12669     -44     
  Branches        1589    1593      +4     
===========================================
- Hits            5898    5790    -108     
- Misses          6175    6230     +55     
- Partials         640     649      +9
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/io/seata/core/rpc/ChannelManager.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...java/io/seata/server/metrics/MeterIdConstants.java 0% <0%> (-96.56%) 0% <0%> (-1%)
...ava/io/seata/server/metrics/MetricsSubscriber.java 0% <0%> (-79.42%) 0% <0%> (-7%)
...n/java/io/seata/server/metrics/MetricsManager.java 0% <0%> (-76.93%) 0% <0%> (-5%)
...in/java/io/seata/server/session/GlobalSession.java 79.8% <0%> (-4.81%) 59% <0%> (-8%)
.../java/io/seata/rm/datasource/DataCompareUtils.java 70.73% <0%> (-4.62%) 27% <0%> (+2%)
...o/seata/server/coordinator/DefaultCoordinator.java 50% <0%> (-3.22%) 25% <0%> (-3%)
...seata/rm/datasource/sql/struct/TableMetaCache.java 50.62% <0%> (-1.23%) 12% <0%> (-1%)
...seata/rm/datasource/undo/AbstractUndoExecutor.java 83.15% <0%> (-0.02%) 20% <0%> (-1%)
...codec/protobuf/manager/ProtobufConvertManager.java 100% <0%> (ø) 5% <0%> (ø) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8591dc7...e55fe50. Read the comment docs.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly changed the title Simplify operation of map refactor: simplify operation of map Aug 13, 2019
Copy link
Contributor

@sharajava sharajava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okey to me

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@funky-eyes
Copy link
Contributor

由于前期Seata社区治理规范问题部分代码作者未签署CLA,可能引发社区知识产权风险问题。请所有在Seata社区贡献过代码(包含:主项目、官网、samples和多语言项目等)的 contributor 帮忙在这个链接登录github账号签署相应的开发者CLA,https://cla-assistant.io/seata/seata 。2023.1.31 未签署CLA的代码将会被rewrite,拜托大家帮忙签一下。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants