-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: simplify operation of map #1444
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1444 +/- ##
===========================================
- Coverage 46.39% 45.7% -0.7%
+ Complexity 1691 1664 -27
===========================================
Files 347 345 -2
Lines 12713 12669 -44
Branches 1589 1593 +4
===========================================
- Hits 5898 5790 -108
- Misses 6175 6230 +55
- Partials 640 649 +9
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ed16b42
to
5d2818d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okey to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
由于前期Seata社区治理规范问题部分代码作者未签署CLA,可能引发社区知识产权风险问题。请所有在Seata社区贡献过代码(包含:主项目、官网、samples和多语言项目等)的 contributor 帮忙在这个链接登录github账号签署相应的开发者CLA,https://cla-assistant.io/seata/seata 。2023.1.31 未签署CLA的代码将会被rewrite,拜托大家帮忙签一下。 |
Ⅰ. Describe what this PR did
Simplify some redundant code of operation of map
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews