Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature:support oracle batch operation #1447

Merged
merged 5 commits into from
Aug 14, 2019

Conversation

zjinlei
Copy link
Contributor

@zjinlei zjinlei commented Aug 12, 2019

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Oracle batch insert exists rowId problem is not resolved

@codecov-io
Copy link

codecov-io commented Aug 12, 2019

Codecov Report

Merging #1447 into develop will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1447      +/-   ##
=============================================
- Coverage      45.72%   45.71%   -0.01%     
  Complexity      1664     1664              
=============================================
  Files            345      345              
  Lines          12666    12673       +7     
  Branches        1589     1593       +4     
=============================================
+ Hits            5791     5793       +2     
- Misses          6227     6233       +6     
+ Partials         648      647       -1
Impacted Files Coverage Δ Complexity Δ
...ource/sql/druid/oracle/OracleUpdateRecognizer.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ta/rm/datasource/exec/SelectForUpdateExecutor.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ource/sql/druid/oracle/OracleDeleteRecognizer.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../rm/datasource/exec/BaseTransactionalExecutor.java 17.39% <0%> (ø) 6 <0> (ø) ⬇️
...va/io/seata/rm/datasource/exec/DeleteExecutor.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...va/io/seata/rm/datasource/exec/UpdateExecutor.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../druid/oracle/OracleSelectForUpdateRecognizer.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../seata/rm/datasource/sql/druid/BaseRecognizer.java 50% <0%> (-30%) 3 <0> (ø)
...very/registry/zk/ZookeeperRegisterServiceImpl.java 63.77% <0%> (-0.79%) 24% <0%> (ø)
...server/store/file/FileTransactionStoreManager.java 47.38% <0%> (+1.04%) 19% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc05983...f0e1b24. Read the comment docs.

@zjinlei zjinlei changed the title adapt oracle batch operation adapt oracle batch operation(wait pr 1448) Aug 13, 2019
@zjinlei
Copy link
Contributor Author

zjinlei commented Aug 13, 2019

Conflict with other pr

@zjinlei zjinlei closed this Aug 13, 2019
@zjinlei zjinlei changed the title adapt oracle batch operation(wait pr 1448) adapt oracle batch operation(Pending conflict resolution) Aug 13, 2019
@zjinlei zjinlei changed the title adapt oracle batch operation(Pending conflict resolution) adapt oracle batch operation Aug 13, 2019
@zjinlei zjinlei reopened this Aug 13, 2019
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly changed the title adapt oracle batch operation feature:adapt oracle batch operation Aug 14, 2019
Copy link
Contributor

@sharajava sharajava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okey to me

@slievrly slievrly changed the title feature:adapt oracle batch operation feature:support oracle batch operation Aug 14, 2019
@slievrly slievrly merged commit 0159009 into apache:develop Aug 14, 2019
@zjinlei zjinlei deleted the feature/adapterOracleBatch branch August 16, 2019 12:30
@wangliang181230 wangliang181230 added this to the 0.8.1 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants