-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature:support oracle batch operation #1447
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1447 +/- ##
=============================================
- Coverage 45.72% 45.71% -0.01%
Complexity 1664 1664
=============================================
Files 345 345
Lines 12666 12673 +7
Branches 1589 1593 +4
=============================================
+ Hits 5791 5793 +2
- Misses 6227 6233 +6
+ Partials 648 647 -1
Continue to review full report at Codecov.
|
Conflict with other pr |
rm-datasource/src/main/java/io/seata/rm/datasource/exec/BaseTransactionalExecutor.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okey to me
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews
Oracle batch insert exists rowId problem is not resolved