refactor: executor class duplicate code #1448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1448 +/- ##
=============================================
+ Coverage 45.43% 45.65% +0.21%
Complexity 1664 1664
=============================================
Files 345 345
Lines 12708 12641 -67
Branches 1611 1588 -23
=============================================
- Hits 5774 5771 -3
+ Misses 6287 6222 -65
- Partials 647 648 +1
Continue to review full report at Codecov.
|
slievrly
reviewed
Aug 13, 2019
| break; | ||
| } | ||
| } catch (LockConflictException lce) { | ||
| conn.rollback(sp); |
There was a problem hiding this comment.
should in while block？
done
fix import order
andyqian
changed the title
slievrly
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
remove duplicate code