-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: support delete expired undolog use protobuf #1453
feature: support delete expired undolog use protobuf #1453
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1453 +/- ##
=============================================
+ Coverage 45.68% 45.74% +0.06%
- Complexity 1664 1667 +3
=============================================
Files 345 346 +1
Lines 12675 12662 -13
Branches 1593 1588 -5
=============================================
+ Hits 5790 5792 +2
+ Misses 6236 6222 -14
+ Partials 649 648 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Ⅰ. Describe what this PR did
support undolog delete request protobuf
Ⅱ. Does this pull request fix one issue?
support undolog delete request protobuf
Ⅲ. Why don't you add test cases (unit test/integration test)?
UndoLogDeleteRequestRequestConvertorTest
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews