Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: support delete expired undolog use protobuf #1453

Merged
merged 5 commits into from
Aug 16, 2019

Conversation

github-ygy
Copy link
Contributor

Ⅰ. Describe what this PR did

support undolog delete request protobuf

Ⅱ. Does this pull request fix one issue?

support undolog delete request protobuf

Ⅲ. Why don't you add test cases (unit test/integration test)?

UndoLogDeleteRequestRequestConvertorTest

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Aug 13, 2019

Codecov Report

Merging #1453 into develop will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1453      +/-   ##
=============================================
+ Coverage      45.68%   45.74%   +0.06%     
- Complexity      1664     1667       +3     
=============================================
  Files            345      346       +1     
  Lines          12675    12662      -13     
  Branches        1593     1588       -5     
=============================================
+ Hits            5790     5792       +2     
+ Misses          6236     6222      -14     
+ Partials         649      648       -1
Impacted Files Coverage Δ Complexity Δ
...codec/protobuf/manager/ProtobufConvertManager.java 100% <100%> (ø) 5 <0> (ø) ⬇️
...tobuf/convertor/UndoLogDeleteRequestConvertor.java 100% <100%> (ø) 3 <3> (?)
...m/datasource/undo/parser/JacksonUndoLogParser.java 55.55% <0%> (-9.57%) 4% <0%> (ø)
...va/io/seata/rm/datasource/exec/UpdateExecutor.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...ta/rm/datasource/exec/SelectForUpdateExecutor.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...o/seata/server/coordinator/DefaultCoordinator.java 50% <0%> (ø) 25% <0%> (ø) ⬇️
...va/io/seata/rm/datasource/exec/DeleteExecutor.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...ource/sql/druid/oracle/OracleDeleteRecognizer.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...ource/sql/druid/oracle/OracleUpdateRecognizer.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
.../druid/oracle/OracleSelectForUpdateRecognizer.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 417c3ee...e30e5ee. Read the comment docs.

@github-ygy github-ygy requested review from xingfudeshi, slievrly, xuririse and CoffeeLatte007 and removed request for xuririse August 13, 2019 11:57
@slievrly slievrly changed the title support undolog delete request protobuf feature: support delete expired undolog use protobuf Aug 15, 2019
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use serialization = "protobuf" verification passed.
image

@zjinlei
Copy link
Contributor

zjinlei commented Aug 15, 2019

Change the server interval to 1 second, insert data dynamically, and run well.
image

Copy link
Contributor

@leizhiyuan leizhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@slievrly slievrly merged commit 80a55ab into apache:develop Aug 16, 2019
@wangliang181230 wangliang181230 added this to the 0.8.1 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants