Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: DateCompareUtils can not compare byte array #1454

Merged
merged 24 commits into from
Aug 14, 2019

Conversation

l81893521
Copy link
Contributor

Ⅰ. Describe what this PR did

use deep equals to compare byte array

Ⅱ. Does this pull request fix one issue?

#1451

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Aug 13, 2019

Codecov Report

Merging #1454 into develop will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1454      +/-   ##
=============================================
- Coverage      45.71%   45.67%   -0.04%     
  Complexity      1664     1664              
=============================================
  Files            345      345              
  Lines          12673    12673              
  Branches        1593     1593              
=============================================
- Hits            5793     5789       -4     
- Misses          6232     6235       +3     
- Partials         648      649       +1
Impacted Files Coverage Δ Complexity Δ
.../java/io/seata/rm/datasource/DataCompareUtils.java 70.73% <100%> (ø) 27 <0> (ø) ⬇️
...server/store/file/FileTransactionStoreManager.java 45.99% <0%> (-1.05%) 19% <0%> (ø)
...very/registry/zk/ZookeeperRegisterServiceImpl.java 63.77% <0%> (-0.79%) 24% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73cd6d3...8b303ac. Read the comment docs.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@sharajava sharajava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okey to me

@slievrly slievrly merged commit 20882f0 into apache:develop Aug 14, 2019
@l81893521 l81893521 deleted the fix_byte_not_equal branch August 15, 2019 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants