-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: DateCompareUtils can not compare byte array #1454
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1454 +/- ##
=============================================
- Coverage 45.71% 45.67% -0.04%
Complexity 1664 1664
=============================================
Files 345 345
Lines 12673 12673
Branches 1593 1593
=============================================
- Hits 5793 5789 -4
- Misses 6232 6235 +3
- Partials 648 649 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rm-datasource/src/main/java/io/seata/rm/datasource/DataCompareUtils.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okey to me
Ⅰ. Describe what this PR did
use deep equals to compare byte array
Ⅱ. Does this pull request fix one issue?
#1451
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews